-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unwrapping logic in strategies #13738
Conversation
for more information, see https://pre-commit.ci
…actor/remove-unwrap
for more information, see https://pre-commit.ci
…actor/remove-unwrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the description! It helped me review the change :) LGTM!
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
…actor/remove-unwrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could add comlpete version, it'd be nice.
else looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
What does this PR do?
Fixes #13502 (main RFC)
Fixes #8593
Fixes #13500
The PR looks big, but most complexity turns out to be in the deprecation. The rest of the changes are very thinly spread across multiple files, but are not complex by themselves.
Before, you would do
Now, directly access it:
Terminology:
self.model
: refers to a LightningModule that is potentially wrappedself.lightning_module
: is always the pure LightningModule as it gets passed to Trainer.fit by the user. This attribute is read-access only.TODOs:
Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @awaelchli @rohitgr7 @tchaton @akihironitta